Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unicode_ascii.rakudoc #4553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update unicode_ascii.rakudoc #4553

wants to merge 1 commit into from

Conversation

finanalyst
Copy link
Collaborator

The problem

Regularise X<> in headings
Placing the term whitespace outside the X<> has an effect on the rendering in the title. It seems to be the only example of this form in a heading in all the Raku/docs/doc repo. Tested with rak '/^\=head\d\s+X\<\| /' raku-docs (raku-docs is a local clone of Raku/docs)

Solution provided

Placing the term whitespace inside the X<>

Regularise X<> in headings
Placing the term whitespace outside the `X<>` has an effect on the rendering in the title.
It seems to be the only example of this form in a heading in all the Raku/docs/doc repo.
Tested with `rak '/^\=head\d\s+X\<\| /' raku-docs` (**raku-docs** is a local clone of Raku/docs)
@finanalyst finanalyst requested a review from dontlaugh January 18, 2025 11:05
@finanalyst
Copy link
Collaborator Author

@dontlaugh @coke I'm finding these subtle outliers as I'm refactoring the generation of secondaries, search, routines page, types page and the index - they were all jumbled together in an ad hoc fashion.

@coke
Copy link
Collaborator

coke commented Jan 18, 2025

Should this be a style we check for and disallow in a test, or will it eventually cause a compilation error?

@finanalyst
Copy link
Collaborator Author

finanalyst commented Jan 19, 2025 via email

@dontlaugh
Copy link
Contributor

@finanalyst will you add that style check to this PR? then we can approve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants