Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequre T55 Support #1928

Merged
merged 15 commits into from
Jul 24, 2024
Merged

Sequre T55 Support #1928

merged 15 commits into from
Jul 24, 2024

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Jun 8, 2024

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?

Adding support for the T55 hotplate.
Closes #1885.

  • What is the current behavior?
  • What is the new behavior (if this is a feature change)?

  • Other information:

Like all Sequre devices, the unit is designed to minimum cost. So there is no inductor or enough caps to filter out noise.
We get some PWM hum when running it as fast as we can to keep current regulation smooth.

@Ralim Ralim changed the title WIP: Sequre T55 Support Sequre T55 Support Jun 8, 2024
@Ralim Ralim marked this pull request as ready for review June 8, 2024 10:36
@StevenSeifried
Copy link
Contributor

As already commented in #1885: LGTM
The only "issue" I noticed is, that some descriptions are a bit cut at the end.

@Ralim
Copy link
Owner Author

Ralim commented Jun 27, 2024

Thanks for testing, can you list some examples of what is cut off ?

@StevenSeifried
Copy link
Contributor

I clicked through all the settings and all the descriptions are cut off at the end.

e.g. Soldering settings -> Temp change short

20240627_065305

@StevenSeifried
Copy link
Contributor

Perhaps this is because the full OLED resolution is not yet supported

@ReimuHakurei
Copy link
Contributor

Just got one of these and tested the firmware.

It's possible this issue is something broken on my end when building (the CI artifacts have expired so I can't test an official build for this), but the localization strings for the profile support seem to be missing, resulting in a blank menu item for all of those settings.

When I deleted all the include keys from the translations_definitions.json file and rebuilt, it displays fine. Not familiar with the codebase so couldn't find any obvious cause why those would be missing in the build.

@Ralim
Copy link
Owner Author

Ralim commented Jul 17, 2024

@ReimuHakurei
I have not been able to replicate the profile mode issues you have mentioned here.
How did you build the firmware?

@StevenSeifried I believe the cut off should be fixed 😓

@ReimuHakurei
Copy link
Contributor

I compiled the firmware with make docker-build on Ubuntu 22.04. The tests crash on that same system (looks like clang-format shipped on 22.04 is likely too old to support the config in this repo) so it wouldn't surprise me one bit if its my build environment.

I'll test the latest CI artifact this evening and see if it works properly there.

@StevenSeifried
Copy link
Contributor

I believe the cut off should be fixed 😓

@Ralim the cut off seems to be fixed. I tested with the current version from GitHub actions (German and English). I didn't click through all the settings and all the descriptions in both languages, just checked a few, but none of them was cut off

@Ralim
Copy link
Owner Author

Ralim commented Jul 18, 2024

@ReimuHakurei yeah that would make sense. I advise to do all commands inside the docker container to ensure we are all using the same tooling. Can you check it's working fine in the CI builds to compare against ?

@ReimuHakurei
Copy link
Contributor

Can confirm it works correctly in the CI build.

@ReimuHakurei
Copy link
Contributor

ReimuHakurei commented Jul 18, 2024

Another observation: I assume this is an issue in the dev branch and is just showing up here from the rebase earlier, but while it still seems to enter profile mode when you hold the button, it is no longer displaying details (ie: time elapsed / remaining / current phase / target temperature). This is with detailed idle/soldering view set; not sure how it's supposed to look otherwise as I always use the detailed views.

@Ralim
Copy link
Owner Author

Ralim commented Jul 18, 2024

This is most likely something missing in the drawing modes for the higher res oled screen. I'll try and have a look tonight

@Ralim
Copy link
Owner Author

Ralim commented Jul 23, 2024

Phase printing should work now I think

@valzzu
Copy link

valzzu commented Jul 23, 2024

I just got T55 today and found this, hows the firmware coming along?

@StevenSeifried
Copy link
Contributor

I just got T55 today and found this, hows the firmware coming along?

Only @Ralim can tell it excactly, but I'm optimistic that the T55 will be officially supported with 2.23

@valzzu
Copy link

valzzu commented Jul 23, 2024

Cool

@Ralim
Copy link
Owner Author

Ralim commented Jul 24, 2024

Hardware should work, just the UI is limited

@Ralim Ralim merged commit d9c88c9 into dev Jul 24, 2024
36 checks passed
@Ralim Ralim deleted the Sequre-T55 branch July 24, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Sequre T55 hot plate
5 participants