Check the presence of changelog for the latest stable release in History.md #1999
+100
−54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Detecting the presence of changelog for the latest stable release in
History.md
.What is the current behavior?
We should add changelog manually but sometimes we may forget because there is no any test check for this.
What is the new behavior (if this is a feature change)?
Extend test step for docs using GitHub Actions with the following algorithm: check
History.md
for the latest stable release, checkgit tag
for the latest stable release, and if they mismatch then trigger error.Other information:
Not sure how it will work at the moment of tagging though. I guess we will see. :)
But basically now the push of the new release tag to
dev
must be with the same commit of changelog toHistory.md
. Otherwise there will be a reminder in the form of red build, but next commit of changes toHistory.md
probably will fix it. That's the point after all.Another one important notice for contributors, or what's new today I learned about git/hub: sometimes tags must be synced manually because for some reason just merging with upstream is not enough to sync some metadata such as tags, i.e.:
Without this, Actions in forked repos may not be fetching the latest actual git tags from
upstream
even if anything else is properly merged, synced, and up-to-dated. 🤷♂️