-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed Get/Set config #18
base: master
Are you sure you want to change the base?
Conversation
are creating a SecretServer_$($env:USERNAME).xml and the psm1 is looking for SecretServer.xml. If you want to implement a config per user I would store it in ~ \SecretServer
are creating a SecretServer_$($env:USERNAME).xml and the psm1 is looking for SecretServer.xml. If you want to implement a config per user I would store it in ~ \SecretServer
Conflicts: SecretServer/Public/Get-SecretServerConfig.ps1 SecretServer/Public/Set-SecretServerConfig.ps1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you've overlooked the fact that this module expects to be built (with the build.ps1 script).
These path changes might be fine if you're running it from source control, but that's not how it's deployed. You can't write in $PSScriptRoot.. because after build that would be the "Modules" folder.
Oke but where during the build do you supply the url to SecretServer? since And yes I am trying to make this work in a build script and don't like the Op ma 26 sep. 2016 om 07:02 schreef Joel Bennett [email protected]:
|
You don't supply the url at build time. Users have have to supply the url. I guess the confusion is that nobody bothered deleting the .psm1 from source control -- that file does not end up in the module output by the build. The .psm1 is generated by the build script from all the script files. From the developer point of view, the idea is that you run Anyway. Users set the URL (using |
Only thing I dont get is why you store it in an XML then when you always need to run New-SSConnection after import / before use. Just keep it in the variable SecretServerConfig at all times. If you "stored" it you would need to retreive the config with Get-SSconfig before use (which i just as much effort as New-SSconfig if you don't know for sure it's there ;) |
If I ever get around to doing more work on this ... one of the things I would so is load the config automatically at module import once it's been configured ... |
Shouldn't be hard to do, check if xml exist if so bla bla ... will see If I Op ma 24 okt. 2016 om 06:01 schreef Joel Bennett [email protected]:
|
Get/Set config are creating a SecretServer_$($env:USERNAME).xml and the psm1 is looking for SecretServer.xml. If you want to implement a config per user I would store it in ~ \SecretServer