Support Cataclysm Classic #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's 1 change here that applies to all versions of WoW instead of just Cataclysm Classic. That's the change to the
SetParentcall argument inModules/ShowHide.lua, which is because as of October 2022,SetParentno longer accepts a string argument, so the global frame reference must be passed instead.Otherwise, all changes simply copy the behavior of Wrath Classic, which seems to work just fine in my in-game testing.
This depends on the update to LibIsClassic, which you can review and merge at Ravendwyr/LibIsClassic-1.0#1.