-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: angular migration v19 #55
feat: angular migration v19 #55
Conversation
c22bdba
to
40b329b
Compare
Thank you, and yes, Angular 19 already – time flies! I’ve sent you an invite to become a maintainer. Feel free to merge into develop whenever you want. I’ll let you finish the version upgrade. |
d44dd10
to
56afe98
Compare
56afe98
to
40b6b0b
Compare
projects/ngx-monaco-tree/src/lib/monaco-tree-context-menu/monaco-tree-context-menu.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-monaco-tree/src/lib/monaco-tree-file/monaco-tree-file.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-monaco-tree/src/lib/monaco-tree-file/monaco-tree-file.component.ts
Show resolved
Hide resolved
projects/ngx-monaco-tree/src/lib/monaco-tree-file/monaco-tree-file.component.ts
Outdated
Show resolved
Hide resolved
f84bbb8
to
e3f76b1
Compare
Hello @RawZ06, |
Thanks a lot! I won’t merge it for now—I’ll take the time to study it on my end. I haven’t had the time lately, but I’ll do it as soon as possible. |
I would like to congratulate you on the work; it’s very, very clean. You have adhered to the standards with Angular signals—it’s an excellent job. Thank you so much for the time you dedicated to it. Thanks also to @fpaul-1A for the reviews. Well done, I’m merging! |
I don't know how you handle the releasing of this project.
I did the migration to Angular v19 and new APIs like (inject, input-signal, output, control flows). I splitted it in several commit in case you don't want all of them.
For the input-signal 3 inputs has not been migrated (flagged with TODO) because their values are modified in the component, we may think to use
model
instead.