Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: angular migration v19 #55

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

matthieu-crouzet
Copy link
Collaborator

I don't know how you handle the releasing of this project.
I did the migration to Angular v19 and new APIs like (inject, input-signal, output, control flows). I splitted it in several commit in case you don't want all of them.
For the input-signal 3 inputs has not been migrated (flagged with TODO) because their values are modified in the component, we may think to use model instead.

@RawZ06
Copy link
Owner

RawZ06 commented Dec 10, 2024

Thank you, and yes, Angular 19 already – time flies! I’ve sent you an invite to become a maintainer. Feel free to merge into develop whenever you want. I’ll let you finish the version upgrade.

@matthieu-crouzet matthieu-crouzet force-pushed the feat/angular-migration branch 2 times, most recently from d44dd10 to 56afe98 Compare December 12, 2024 17:21
@matthieu-crouzet
Copy link
Collaborator Author

Hello @RawZ06,
I think this PR is ready to be merged, but I don't how you handle the releasing of a new major.
So I will let you merge that PR if you are okay with it and deploy a new major version of that package.
Thank you ! 😄

@RawZ06
Copy link
Owner

RawZ06 commented Feb 2, 2025

Thanks a lot! I won’t merge it for now—I’ll take the time to study it on my end. I haven’t had the time lately, but I’ll do it as soon as possible.

@RawZ06
Copy link
Owner

RawZ06 commented Feb 7, 2025

I would like to congratulate you on the work; it’s very, very clean. You have adhered to the standards with Angular signals—it’s an excellent job. Thank you so much for the time you dedicated to it. Thanks also to @fpaul-1A for the reviews. Well done, I’m merging!

@RawZ06 RawZ06 merged commit 6afd027 into RawZ06:develop Feb 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants