Avoid quadratic runtime when merging text nodes #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the newly added
text
stress test/benchmark finishes in about a minute instead of I-did-not-wait-that-long.However, it does also regress the real-world XMLwhich I am still looking into. I guess the common case of really just one borrowed text got slower.The real-world XML files are basically flat
after I compressed the state space and made use of the fact that
StringStorage::new_owned
always creates a new allocation so that I can keep the original buffer around for if another text node need to be merged while still already leaving a fully formed text in the tree. (Note that these files never exercise the merging code path at all.)