Column naming for empty string and duplicate NA label #6795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6795 +/- ##
==========================================
- Coverage 98.60% 98.58% -0.02%
==========================================
Files 79 79
Lines 14642 14657 +15
==========================================
+ Hits 14438 14450 +12
- Misses 204 207 +3 ☔ View full report in Codecov by Sentry. |
tdhock
requested changes
Feb 4, 2025
There was a problem hiding this comment.
before asking for review, please click "Files changed" tab and make sure that only a minimal set of changes that is relevant to the PR appears.
here there are many irrelevant changes should be reverted before review (adding empty lines, and removing comments)
R/fcast.R
Outdated
| @@ -147,18 +162,21 @@ dcast.data.table = function(data, formula, fun.aggregate = NULL, sep = "_", ..., | |||
| if (is.function(dat[[i]])) | |||
| stopf("Column [%s] not found or of unknown type.", deparse(x)) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
please undo addition of empty lines
R/fcast.R
Outdated
| @@ -168,9 +186,10 @@ dcast.data.table = function(data, formula, fun.aggregate = NULL, sep = "_", ..., | |||
| subset = m[["subset"]][[2L]] | |||
| if (!is.null(subset)) { | |||
| if (is.name(subset)) subset = as.call(list(quote(`(`), subset)) | |||
| idx = which(eval(subset, data, parent.frame())) # any advantage thro' secondary keys? | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5605
This PR addresses the issues of Handling empty strings with "empty_string" and ensuring unique column.
Handling Empty Strings in Column Names
Added a function handle_empty_strings to replace empty strings in column names with "empty_string".
Ensuring Unique Column Names
Added a function ensure_unique_names to ensure column names are unique by appending a suffix if duplicates are found.
Improved fill.default Handling
Explicitly handled fill.default when fun.aggregate is used and fill is NULL.
When fun.aggregate is used and fill is NULL, missing values in the reshaped data need to be filled with a default value.This change ensures that fill.default is computed correctly and used to fill missing values, improving consistency and preventing errors.
Added a check to ensure the length of names matches the length of the vector before setting the names attribute.
if there is any improvement needed in the code than tell me.