Coc funding update #6803
Coc funding update #6803
Conversation
Seal_of_Approval.md created and added to R build ignore
- Add link to Seal of Approval doc - Add links to social media accounts and The Raft
Three packages proposed for Seal: - nc: By Toby, adds regular expressions to data.table - tidyfast: By Tyson, implements dplyr-like verbs with only data.table as a dependency - dtplyr: By Hadley, adds data.table backend to dplyr verbs. Merging of this PR by a maintainer will consistute Approval on these three packages!
|
Hi all, The proposed changes here are to help data.table be more aligned with the Code of Conduct approach for other major package projects. Notable changes for discussion:
Let me know if these proposals sound good to you all! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6803 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 79 79
Lines 14639 14642 +3
=======================================
+ Hits 14440 14444 +4
+ Misses 199 198 -1 ☔ View full report in Codecov by Sentry. |
.github/CODE_OF_CONDUCT.md
Outdated
|
|
||
| Project members with the Committer role or the CRAN Maintainer role are pledged to promptly address any reported issues. Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to any individual with this role. | ||
|
|
||
| Those who prefer to report in a way that is anonymous to the project maintainers may instead contact the Community Engagement Coordinator by e-mailing [r.data.table\@gmail.com](mailto:[email protected]). Messages sent to this e-mail address will be publicly visible only to the current Community Engagement Coordinator, a position always held by an individual who is not a Committer or CRAN Maintainer of the package. |
There was a problem hiding this comment.
please remove "publicly" because that seems to contradict "visible only to the current Community Engagement Coordinator"
.github/CODE_OF_CONDUCT.md
Outdated
|
|
||
| Those who prefer to report in a way that is anonymous to the project maintainers may instead contact the Community Engagement Coordinator by e-mailing [r.data.table\@gmail.com](mailto:[email protected]). Messages sent to this e-mail address will be publicly visible only to the current Community Engagement Coordinator, a position always held by an individual who is not a Committer or CRAN Maintainer of the package. | ||
|
|
||
| The current Contributors are Toby Hocking, Toby Dylan Hocking (@tdhock), Matt Dowle (@mattdowle), Arun Srinivasan (@arunsrinivasan), Jan Gorecki (@jangorecki), Michael Chirico (@MichaelChirico), and Benjamin Schwendinger (@ben-schwen). |
There was a problem hiding this comment.
I think it would be better if we could remove the names here and instead reference the DESCRIPTION file, what do you think?
There was a problem hiding this comment.
I could be convinced either way but just for workflow purposes having a single place (ie Description) to make the change makes some sense to me. But is that information clear enough in the Description?
There was a problem hiding this comment.
The example CoC's that I was working off of gave these contacts from within the CoC. I guess it would be okay to point to the "aut" role in the DESCRIPTION... but I personally would be in favor of the duplication, for clarity.
(Also sorry I listed Toby twice, fixed now!)
There was a problem hiding this comment.
The other thing is that the DESCRIPTION doesn't have GitHub handles, and only has emails for 3 of the 6 committers... I think if we got emails in there for all 6, then it would be ok to just point to DESCRIPTION.
| @@ -72,6 +72,14 @@ Functionality that is out of current scope: | |||
| * How to obtain this role: (1) merge into master a PR adding role="cre" to DESCRIPTION, and (2) submit updated package to CRAN (previous CRAN Maintainer will have to confirm change by email to CRAN). | |||
| * How this role is recognized: credited via role="cre" in DESCRIPTION, so they appear as Maintainer on CRAN. | |||
|
|
|||
| ## Community Engagement Coordinator | |||
|
|
|||
| * Definition: An individual who is involved in the project but does **not** also occupy the Committer or CRAN Maintainer role. In charge of maintaining The Raft blog, preparing Seal of Approval Applications, addressing Code of Conduct violations, and planning social or community events. | |||
GOVERNANCE.md
Outdated
| As contributors of this project, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities. | ||
|
|
||
| We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, religion, etc. |
There was a problem hiding this comment.
since this part is redundant with the newly added CODE_OF_CONDUCT.md, I would suggest removing it here, what you think?
There was a problem hiding this comment.
I agree since we specifically reference the CoC in this doc already.
| @@ -98,19 +106,43 @@ There is no special process for changing this document. Submit a PR and ask for | |||
|
|
|||
| Please also make a note in the change log under [`# Governance history`](#governance-history) | |||
|
|
|||
| # Finances and Funding | |||
There was a problem hiding this comment.
This section is great. Calls out the various ways money could come in.
GOVERNANCE.md
Outdated
| As contributors of this project, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities. | ||
|
|
||
| We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, religion, etc. |
There was a problem hiding this comment.
I agree since we specifically reference the CoC in this doc already.
.github/CODE_OF_CONDUCT.md
Outdated
|
|
||
| Those who prefer to report in a way that is anonymous to the project maintainers may instead contact the Community Engagement Coordinator by e-mailing [r.data.table\@gmail.com](mailto:[email protected]). Messages sent to this e-mail address will be publicly visible only to the current Community Engagement Coordinator, a position always held by an individual who is not a Committer or CRAN Maintainer of the package. | ||
|
|
||
| The current Contributors are Toby Hocking, Toby Dylan Hocking (@tdhock), Matt Dowle (@mattdowle), Arun Srinivasan (@arunsrinivasan), Jan Gorecki (@jangorecki), Michael Chirico (@MichaelChirico), and Benjamin Schwendinger (@ben-schwen). |
There was a problem hiding this comment.
I could be convinced either way but just for workflow purposes having a single place (ie Description) to make the change makes some sense to me. But is that information clear enough in the Description?
|
|
||
| Those who prefer to report in a way that is anonymous to the project maintainers may instead contact the Community Engagement Coordinator by e-mailing [r.data.table\@gmail.com](mailto:[email protected]). Messages sent to this e-mail address will be visible only to the current Community Engagement Coordinator, a position always held by an individual who is not a Committer or CRAN Maintainer of the package. | ||
|
|
||
| The current Committers are Toby Dylan Hocking (@tdhock), Matt Dowle (@mattdowle), Arun Srinivasan (@arunsrinivasan), Jan Gorecki (@jangorecki), Michael Chirico (@MichaelChirico), and Benjamin Schwendinger (@ben-schwen). |
There was a problem hiding this comment.
This is out of date (Ivan K. is recently added); rather than keep a manual list, should we point to this link instead?
https://github.com/orgs/Rdatatable/teams/committers
It's less important for the CRAN Maintainer & CEC roles because they're only one person, but still Tyson can also be found as "Release manager":
https://github.com/orgs/Rdatatable/teams/release-managers
And we could add a team for Kelly as Community Engagement Coordinator
There was a problem hiding this comment.
These links would be ideal but they are only visible to org members. :(
There was a problem hiding this comment.
Oh, I see. Hmm. Well, let's try both then:
The current Committers (@Rdatatable/committers) are ...
That points to the group @Rdatatable/committers as a source-of-truth even if this manual list gets out of date.
There was a problem hiding this comment.
I suggest using DESCRIPTION which is public and should be up to date with github teams.
There was a problem hiding this comment.
DESCRIPTION has all Members though, where this is about Committers
GOVERNANCE.md
Outdated
|
|
||
| * Definition: An individual who is involved in the project but does **not** also occupy the Committer or CRAN Maintainer role. In charge of maintaining The Raft blog, preparing Seal of Approval Applications, addressing Code of Conduct violations, and planning social or community events. | ||
|
|
||
| * How to obtain this role: Contact the current Community Engagement Coordinator. |
There was a problem hiding this comment.
I think more important for this role is "how a new CEC is selected", it might make sense to think of how you'd pass on responsibilities if you so chose in the future. Would it just be someone chosen by you? Should we get Consensus from existing Committers?
GOVERNANCE.md
Outdated
|
|
||
| Committers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct. A person with special roles who does not follow the Code of Conduct may have their roles revoked. | ||
| Direct donations to the project may be made via GitHub Sponsorships, which allow individuals to fund a specific developer. Those wishing to support the project in general, rather than a specific developer, should direct their donations to the current CRAN Maintainer. |
There was a problem hiding this comment.
If I'm reading correctly, Tyson would need to have Sponsorships activated, is that right? (He may have done so already, I couldn't tell from glancing at the profile).
There was a problem hiding this comment.
Yes, we're chatting about this tomorrow to see if he's willing/able to set that up - but first wanted to see how the team felt about this mechanism.
There was a problem hiding this comment.
I think it will be helpful for transparency to specify what are the acceptable uses of funds allocated in this way. We don't need to get it right (if we think of a smart new way to apply funding), but we can always update the doc.
|
The 2019 book How to Respond to Code of Conduct Reports by Valerie Aurora and Mary Gardiner recommends "publicly committ[ing] to respond by a certain time" from a CoC report (chapters 2, 3). And yet the same book doesn't list the deadline among the things that a code of conduct should contain (chapter 1). Where should the response deadline be listed? |
.github/CODE_OF_CONDUCT.md
Outdated
|
|
||
| Project members with the Committer role have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful. | ||
|
|
||
| By adopting this Code of Conduct, project maintainers commit themselves to fairly and consistently applying these principles to every aspect of managing this project. Project maintainers who do not follow or enforce the Code of Conduct may be permanently removed from the project team. |
There was a problem hiding this comment.
here we mix the terminology of project maintainers and committers? For clarity, we should probably stick to our roles
|
|
||
| Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by opening an issue or emailing one or more of the Committers. | ||
| ## Decision-making for future opportunities |
There was a problem hiding this comment.
this section seems to directly address the numfocus reviewer comment requesting info on "how decisions about distributing funding are made." good!
.github/CODE_OF_CONDUCT.md
Outdated
|
|
||
| Project members with the Committer role or the CRAN Maintainer role are pledged to promptly address any reported issues. Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to any individual with this role. | ||
|
|
||
| Those who prefer to report in a way that is anonymous to the project maintainers may instead contact the Community Engagement Coordinator by e-mailing [r.data.table\@gmail.com](mailto:[email protected]). Messages sent to this e-mail address will be visible only to the current Community Engagement Coordinator, a position always held by an individual who is not a Committer or CRAN Maintainer of the package. |
There was a problem hiding this comment.
anonymous to the project maintainers -> independent of the Committers ?
that would perhaps more directly address the numfocus comment requesting a "specific set of independent contact people to whom to make reports"
| * Publishing other's private information, such as physical or electronic addresses, without explicit permission | ||
| * Other unethical or unprofessional conduct | ||
|
|
||
| Project members with the Committer role have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful. |
There was a problem hiding this comment.
Each commiter should accept this PR before merging
Closes #6769
Closes #6770
adds new CoC and update Gov doc, in an attempt to satisfy NumFOCUS requirements.