Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxExample now uses DispatchTimeInterval #1932

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Conversation

freak4pc
Copy link
Member

RxExample was still using regular TimeInterval(s).

If we change the label as discussed in #1921, I'll change this from:

 .throttle(.milliseconds(500), scheduler: MainScheduler.instance)

to either

 .throttle(for: .milliseconds(500), scheduler: MainScheduler.instance)

or

 .throttle(duration: .milliseconds(500), scheduler: MainScheduler.instance)

@kzaher
Copy link
Member

kzaher commented Apr 15, 2019

throttle(for sounds like the throttling will be performed for the first X period.
throttle(duration, could also be read as throttle for the first X period.

I like the version without parameter because if somebody knows what throttle does, he doesn't need additional info, and if he doesn't nothing can't create a wrong impression.

Let's not do a hasty rename for temporal operators, doesn't sound like an improvement to me.

@kzaher kzaher merged commit a398308 into develop Apr 15, 2019
@freak4pc freak4pc deleted the dispatchtimeinterval-fixup branch April 15, 2019 21:05
@freak4pc
Copy link
Member Author

Makes sense. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants