Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong deprecated message #1959

Merged
merged 1 commit into from
Apr 28, 2019
Merged

Fix wrong deprecated message #1959

merged 1 commit into from
Apr 28, 2019

Conversation

mvolpato
Copy link
Contributor

No description provided.

@freak4pc
Copy link
Member

Nice catch! thank you! :)

@freak4pc freak4pc merged commit 3fba536 into ReactiveX:develop Apr 28, 2019
@mvolpato mvolpato deleted the develop branch April 28, 2019 11:29
@kzaher
Copy link
Member

kzaher commented Apr 28, 2019

@mvolpato @freak4pc
Interesting, I was just creating 5.0.0 tag. Should I wait if somebody is doing some additional tests?

@freak4pc
Copy link
Member

freak4pc commented Apr 28, 2019

This wouldn't cause any real issues (since it's not really public interface, just wrong messaging). We can wait a bit anyways if you'd like.

I suggest taking a look in the dynamic/static discussion - I think there is a question to be answered there @kzaher

@freak4pc
Copy link
Member

@kzaher Was referring to this one:
#1799

Maybe we should make dummy branches on RxDataSources and RxSwiftExt to make sure there are no glaring issues with that release? Anyways the dynamic/static question is a difficult one to answer as well.

@mvolpato
Copy link
Contributor Author

I did not find anything else, but I am not really testing, just starting a new project using Swift 5.

@kzaher
Copy link
Member

kzaher commented Apr 28, 2019

@mvolpato That was what I was thinking of :)

@freak4pc

Maybe we should make dummy branches on RxDataSources and RxSwiftExt to make sure there are no glaring issues with that release?

I have a dummy branch of RxDataSources for integration tests, so I am doing this.

@kzaher
Copy link
Member

kzaher commented Apr 28, 2019

I guess if something will be wrong, we can make a patch release, I don't have any additional way of testing that I already didn't use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants