-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drive() and emit() for multiple observers #1962
Conversation
Hi @freak4pc , wouldn't this change our ABI? |
Hey @kzaher, The method signature itself is different which might mean it's not binary stable - but I'm not sure that's an entirely huge issue as long as we retain the same execution context. If it's a big deal we can easily leave the old signature and relay it into the variadic one. |
@kzaher I think this can be a good time to add this. |
This would be a good addition to RxSwift 6 which should be quite soon. ABI breakage shouldn’t be an issue in that case. |
I just saw this c3c0cac. Does it mean this PR won't be included in RxSwift 6? |
No:
|
6627887
to
b26995e
Compare
b26995e
to
c70cfd8
Compare
To align with
bind(to: Observer...)
(#1702) this PR adds the same abilities todrive()
andemit()
.I also cleaned up some of the implementation (removed an unneeded private method) and removed some duplicate tests for
Driver
.