Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drive() and emit() for multiple observers #1962

Merged
merged 5 commits into from
Dec 21, 2019
Merged

drive() and emit() for multiple observers #1962

merged 5 commits into from
Dec 21, 2019

Conversation

freak4pc
Copy link
Member

@freak4pc freak4pc commented May 4, 2019

To align with bind(to: Observer...) (#1702) this PR adds the same abilities to drive() and emit().

I also cleaned up some of the implementation (removed an unneeded private method) and removed some duplicate tests for Driver.

@freak4pc freak4pc self-assigned this May 4, 2019
@kzaher
Copy link
Member

kzaher commented May 6, 2019

Hi @freak4pc ,

wouldn't this change our ABI?

@freak4pc
Copy link
Member Author

freak4pc commented May 6, 2019

Hey @kzaher,
The code is backward compatible (e.g. drive(observer) works alongside driver(observer1, observer2))

The method signature itself is different which might mean it's not binary stable - but I'm not sure that's an entirely huge issue as long as we retain the same execution context.

If it's a big deal we can easily leave the old signature and relay it into the variadic one.

@freak4pc
Copy link
Member Author

freak4pc commented Oct 3, 2019

@kzaher I think this can be a good time to add this.

@pluddy
Copy link

pluddy commented Dec 2, 2019

This would clean up quite a bit of code repetition we have going on as well. Any way we can keep the conversation going on this @kzaher @freak4pc ?

@freak4pc
Copy link
Member Author

freak4pc commented Dec 2, 2019

This would be a good addition to RxSwift 6 which should be quite soon. ABI breakage shouldn’t be an issue in that case.

@juanjo-ramos
Copy link

I just saw this c3c0cac.

Does it mean this PR won't be included in RxSwift 6?

@freak4pc
Copy link
Member Author

freak4pc commented Dec 17, 2019

No:

  1. It’s just a beta
  2. It wasn’t released yet

@freak4pc freak4pc force-pushed the drive-variadic branch 3 times, most recently from 6627887 to b26995e Compare December 21, 2019 11:34
@freak4pc freak4pc merged commit f49e629 into develop Dec 21, 2019
@freak4pc freak4pc deleted the drive-variadic branch December 21, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants