Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pagination in profile diffs API #2179

Merged
merged 7 commits into from
Sep 28, 2024

Conversation

lakshayman
Copy link
Contributor

@lakshayman lakshayman commented Sep 23, 2024

Date: 23.09/2024

Developer Name: @lakshayman


Issue

Real-Dev-Squad/website-dashboard#849

Description

In this PR, I added pagination to the profile diffs API. I also added another API to access a single profile diff from its ID.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Test Coverage

Screenshot 1

image

@lakshayman lakshayman self-assigned this Sep 23, 2024
routes/profileDiffs.js Dismissed Show dismissed Hide dismissed
@vinit717
Copy link
Member

Can you please link the issue ticket

@lakshayman
Copy link
Contributor Author

Issue added @vinit717. Thanks for pointing it.

Copy link
Member

@tejaskh3 tejaskh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this feature behind feature flag.

test/integration/profileDiffs.test.js Outdated Show resolved Hide resolved
@lakshayman lakshayman force-pushed the feat/paginationInProfileDiffsAPI branch from 4156dc8 to 349df01 Compare September 23, 2024 19:11
@lakshayman lakshayman merged commit 29122bb into develop Sep 28, 2024
3 checks passed
@lakshayman lakshayman deleted the feat/paginationInProfileDiffsAPI branch September 28, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants