Cleanup #27
Merged
Cleanup #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're looking for a place to store Enums, you should make a folder called enums and make individual enums in there. For now, since you only have a single enum you're using in more than one module, it can just stay in the utils folder
Javadocs are for explaining what components do like functions, variables or classes, in the case of separating module categories you should just use comments
Not a huge deal, but was inconsistent between classes and Meteor doesn't have these so using that as standard
Should always be above the constructor, class-specific enums should be at the bottom of the class
This does the exact same thing, no need to try and make it look complex
Much more concise than having a slider with a range of 60 million
Since the only functionality here is turning any HIG related module off it doesn't make a lot of sense to group them into different lists, we can also condense everything into an array which is slightly better memory wise. Lambdas for better readability
Make comments into proper comments, remove the giant block of commented out notifications stuff since it seems to be implemented in NotificationsHelper now
RedCarlos26
requested changes
Jul 19, 2024
RedCarlos26
approved these changes
Jul 20, 2024
RedCarlos26
added a commit
that referenced
this pull request
Jul 24, 2024
commit bee6d78 Author: RedCarlos <[email protected]> Date: Wed Jul 24 00:24:21 2024 -0400 Update README.md commit 8f511ad Author: RedCarlos <[email protected]> Date: Wed Jul 24 00:23:59 2024 -0400 Update README.md commit 6f1cd1c Author: RedCarlos26 <[email protected]> Date: Wed Jul 24 00:07:12 2024 -0400 Temporary stuff commit e484837 Author: RedCarlos26 <[email protected]> Date: Mon Jul 22 20:44:23 2024 -0400 Added HUD text presets commit 9f3efaa Author: RedCarlos26 <[email protected]> Date: Mon Jul 22 20:34:01 2024 -0400 Small things commit 80f6b81 Author: RickyTheRacc <[email protected]> Date: Fri Jul 19 23:10:57 2024 -0500 Merge pull request #27 from RickyTheRacc/code-cleanup * Remove Enums Class * Change Javadocs to Comments * Remove General Comments * Move Variables * Use PlayerUtils in Center Command * Use .noSlider() * Optimize ToggleCommandMixin * Organize AxisViewer * Cleanup HIGUtils * Separate Modules into Categories * Make AFKLogout Settings Clearer * Standardize Event Function Names commit 9cd7f47 Author: RedCarlos26 <[email protected]> Date: Thu Jul 18 14:17:52 2024 -0400 Update README.md commit 97299a6 Author: RedCarlos26 <[email protected]> Date: Thu Jul 18 13:12:33 2024 -0400 Render place even if there is an entity commit bdc33ec Author: RedCarlos26 <[email protected]> Date: Thu Jul 18 13:10:21 2024 -0400 Update gradle.properties commit e4036b2 Author: RedCarlos26 <[email protected]> Date: Sat Jul 13 21:44:06 2024 -0400 Added toggle for statistics commit 07ad243 Author: RedCarlos26 <[email protected]> Date: Sat Jul 13 21:43:53 2024 -0400 Formatting
RedCarlos26
added a commit
that referenced
this pull request
Aug 8, 2024
commit 02e6f52 Author: RickyTheRacc <[email protected]> Date: Thu Aug 8 13:24:42 2024 -0500 Rewrite Hotbar Manager (#28) * Rewriter * Remove Unused Utils * Add Reset Button commit bee6d78 Author: RedCarlos <[email protected]> Date: Wed Jul 24 00:24:21 2024 -0400 Update README.md commit 8f511ad Author: RedCarlos <[email protected]> Date: Wed Jul 24 00:23:59 2024 -0400 Update README.md commit 6f1cd1c Author: RedCarlos26 <[email protected]> Date: Wed Jul 24 00:07:12 2024 -0400 Temporary stuff commit e484837 Author: RedCarlos26 <[email protected]> Date: Mon Jul 22 20:44:23 2024 -0400 Added HUD text presets commit 9f3efaa Author: RedCarlos26 <[email protected]> Date: Mon Jul 22 20:34:01 2024 -0400 Small things commit 80f6b81 Author: RickyTheRacc <[email protected]> Date: Fri Jul 19 23:10:57 2024 -0500 Merge pull request #27 from RickyTheRacc/code-cleanup * Remove Enums Class * Change Javadocs to Comments * Remove General Comments * Move Variables * Use PlayerUtils in Center Command * Use .noSlider() * Optimize ToggleCommandMixin * Organize AxisViewer * Cleanup HIGUtils * Separate Modules into Categories * Make AFKLogout Settings Clearer * Standardize Event Function Names commit 9cd7f47 Author: RedCarlos26 <[email protected]> Date: Thu Jul 18 14:17:52 2024 -0400 Update README.md commit 97299a6 Author: RedCarlos26 <[email protected]> Date: Thu Jul 18 13:12:33 2024 -0400 Render place even if there is an entity commit bdc33ec Author: RedCarlos26 <[email protected]> Date: Thu Jul 18 13:10:21 2024 -0400 Update gradle.properties commit e4036b2 Author: RedCarlos26 <[email protected]> Date: Sat Jul 13 21:44:06 2024 -0400 Added toggle for statistics commit 07ad243 Author: RedCarlos26 <[email protected]> Date: Sat Jul 13 21:43:53 2024 -0400 Formatting
RedCarlos26
added a commit
that referenced
this pull request
Aug 8, 2024
commit 02e6f52 Author: RickyTheRacc <[email protected]> Date: Thu Aug 8 13:24:42 2024 -0500 Rewrite Hotbar Manager (#28) * Rewriter * Remove Unused Utils * Add Reset Button commit bee6d78 Author: RedCarlos <[email protected]> Date: Wed Jul 24 00:24:21 2024 -0400 Update README.md commit 8f511ad Author: RedCarlos <[email protected]> Date: Wed Jul 24 00:23:59 2024 -0400 Update README.md commit 6f1cd1c Author: RedCarlos26 <[email protected]> Date: Wed Jul 24 00:07:12 2024 -0400 Temporary stuff commit e484837 Author: RedCarlos26 <[email protected]> Date: Mon Jul 22 20:44:23 2024 -0400 Added HUD text presets commit 9f3efaa Author: RedCarlos26 <[email protected]> Date: Mon Jul 22 20:34:01 2024 -0400 Small things commit 80f6b81 Author: RickyTheRacc <[email protected]> Date: Fri Jul 19 23:10:57 2024 -0500 Merge pull request #27 from RickyTheRacc/code-cleanup * Remove Enums Class * Change Javadocs to Comments * Remove General Comments * Move Variables * Use PlayerUtils in Center Command * Use .noSlider() * Optimize ToggleCommandMixin * Organize AxisViewer * Cleanup HIGUtils * Separate Modules into Categories * Make AFKLogout Settings Clearer * Standardize Event Function Names commit 9cd7f47 Author: RedCarlos26 <[email protected]> Date: Thu Jul 18 14:17:52 2024 -0400 Update README.md commit 97299a6 Author: RedCarlos26 <[email protected]> Date: Thu Jul 18 13:12:33 2024 -0400 Render place even if there is an entity commit bdc33ec Author: RedCarlos26 <[email protected]> Date: Thu Jul 18 13:10:21 2024 -0400 Update gradle.properties commit e4036b2 Author: RedCarlos26 <[email protected]> Date: Sat Jul 13 21:44:06 2024 -0400 Added toggle for statistics commit 07ad243 Author: RedCarlos26 <[email protected]> Date: Sat Jul 13 21:43:53 2024 -0400 Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to edit actual modules as little as possible, mainly just making formatting consistent with Meteor's and removing commented out code, stuff like that