Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade @redhat-cloud-services/host-inventory-client from 1.5.2 to 2.0.1 #1219

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

jiridostal
Copy link
Collaborator

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json
  • package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Cross-site Request Forgery (CSRF)
SNYK-JS-AXIOS-6032459
  676  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AXIOS-6124857
  586  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Cross-site Request Forgery (CSRF)
🦉 Regular Expression Denial of Service (ReDoS)

@jiridostal jiridostal requested a review from a team as a code owner November 8, 2024 04:18
@gkarat gkarat self-assigned this Feb 5, 2025
@gkarat gkarat added the dependencies Pull requests that update a dependency file label Feb 5, 2025
@gkarat gkarat force-pushed the snyk-fix-02ce97e9d34c4b6236ea357a4c504530 branch from add773b to 6380898 Compare February 6, 2025 13:16
@gkarat gkarat marked this pull request as draft February 7, 2025 09:46
@gkarat gkarat marked this pull request as ready for review February 7, 2025 10:01
@gkarat
Copy link
Contributor

gkarat commented Feb 7, 2025

/retest

@gkarat
Copy link
Contributor

gkarat commented Feb 7, 2025

@RedHatInsights/team-interact, this must be ready. I have manually tested the two affected endpoints and compared both of the responses before/after these changes, and the responses are equal. I assume no further changes required with this upgrade.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.59%. Comparing base (bf6464b) to head (7fdf2dd).

Files with missing lines Patch % Lines
src/Utilities/api.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
- Coverage   63.59%   63.59%   -0.01%     
==========================================
  Files         124      124              
  Lines        3269     3266       -3     
  Branches      860      860              
==========================================
- Hits         2079     2077       -2     
+ Misses       1190     1189       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! OS filter appears to still work as expected! Thank you @jiridostal & @gkarat!

@gkarat gkarat force-pushed the snyk-fix-02ce97e9d34c4b6236ea357a4c504530 branch from 71f0794 to 7fdf2dd Compare February 10, 2025 15:35
@gkarat gkarat enabled auto-merge (squash) February 10, 2025 15:36
@gkarat gkarat disabled auto-merge February 11, 2025 09:24
@gkarat gkarat merged commit 85dba6b into master Feb 11, 2025
4 of 5 checks passed
@gkarat gkarat deleted the snyk-fix-02ce97e9d34c4b6236ea357a4c504530 branch February 11, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants