Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add column management #1231

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: Add column management #1231

wants to merge 5 commits into from

Conversation

leSamo
Copy link
Member

@leSamo leSamo commented Jan 6, 2025 •
edited
Loading

@leSamo leSamo requested a review from a team as a code owner January 6, 2025 23:35
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (0cd38ef) to head (ad1f57f).

Files with missing lines Patch % Lines
...rc/PresentationalComponents/TableView/TableView.js 89.47% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
+ Coverage   63.60%   63.66%   +0.05%     
==========================================
  Files         124      124              
  Lines        3267     3283      +16     
  Branches      860      868       +8     
==========================================
+ Hits         2078     2090      +12     
- Misses       1189     1193       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leSamo leSamo changed the title feat(column mgmt): Add column mgmt to Advisories list table feat: Add column management Jan 9, 2025
@leSamo
Copy link
Member Author

leSamo commented Jan 15, 2025

/ok-to-test

AsToNlele
AsToNlele approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsToNlele AsToNlele AsToNlele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leSamo @codecov-commenter @AsToNlele