fix(RHINENG-13687): convert radio filter to single select #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonm325
force-pushed
the
rhineng-13687
branch
from
7c01da0 to
9395925
Compare
johnsonm325
changed the title
johnsonm325
force-pushed
the
rhineng-13687
branch
from
9395925 to
a4eafa3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1239 +/- ##
==========================================
- Coverage 63.60% 63.59% -0.01%
==========================================
Files 124 124
Lines 3267 3269 +2
Branches 860 860
==========================================
+ Hits 2078 2079 +1
- Misses 1189 1190 +1 ☔ View full report in Codecov by Sentry. |
gkarat
reviewed
Jan 24, 2025
johnsonm325
force-pushed
the
rhineng-13687
branch
2 times, most recently
from
0e547ea to
37b0b1e
Compare
|
@johnsonm325 we get |
johnsonm325
force-pushed
the
rhineng-13687
branch
from
37b0b1e to
8a4e961
Compare
This PR leverages the new conditional filter type singleSelect to convert radio dropdown filters to single select dropdown filters. These filters can be found on Advisories page -> Publish date filter and Systems page -> Updatable filter.
johnsonm325
force-pushed
the
rhineng-13687
branch
from
8a4e961 to
682105a
Compare
|
@LightOfHeaven1994 The Systems table filter should work now. The PR to fix the Inventory Table has been merged: RedHatInsights/insights-inventory-frontend#2337. And the release to production was done today. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the new conditional filter type singleSelect to convert radio dropdown filters to single select dropdown filters. These filters can be found on Advisories page -> Publish date filter and Systems page -> Updatable filter.