Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic support for issue-config file defaults #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add basic support for issue-config file defaults #124

wants to merge 2 commits into from
+65 −19

Conversation

kkaarreell
Copy link
Collaborator

No description provided.

@kkaarreell kkaarreell self-assigned this Nov 14, 2024
@kkaarreell kkaarreell mentioned this pull request Nov 14, 2024
Open
@kkaarreell kkaarreell force-pushed the defaults branch 2 times, most recently from fd6ff9a to e71c4ed Compare November 14, 2024 10:45
@kkaarreell
Copy link
Collaborator Author

kkaarreell commented Nov 14, 2024 •
edited
Loading

Since i am reusing IssueAction class also for newly introduced defaults I had to make all class attributes optional.

lukaszachy
lukaszachy reviewed Nov 14, 2024
View reviewed changes
newa/cli.py Outdated Show resolved Hide resolved
@kkaarreell kkaarreell force-pushed the defaults branch 2 times, most recently from d508419 to 26a44c2 Compare November 18, 2024 14:42
lukaszachy
lukaszachy approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@lukaszachy lukaszachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, however more documentation will be appreciated - seems that if multiple layers of 'include' are used, the defaults is used from the top one (closest to the file used in read_file() call)

@kkaarreell
Copy link
Collaborator Author

Works great, however more documentation will be appreciated - seems that if multiple layers of 'include' are used, the defaults is used from the top one (closest to the file used in read_file() call)

I see. I think that might be relevant for include processing in general. Ideally, users would avoid conflicts. I will test the behavior a bit more and either document it or modify it (if reasonably doable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszachy lukaszachy lukaszachy approved these changes

@happz happz Awaiting requested review from happz

@The-Mule The-Mule Awaiting requested review from The-Mule

Assignees

@kkaarreell kkaarreell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkaarreell @lukaszachy