don't cache varctx (rare operation) #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I found another place where Surprisingly, this is still a performance win in RedPRL, even though we must be calling But these changes are probably going to be superseded anyway by a rewrite of this library that I'm undertaking now. |
|
Should we wait, then? I trust your judgment but am confused by your message. |
|
@favonia I want to try out some more stuff before we merge anything to do with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This operation used to be very frequent in RedPRL (so frequent that I think there was no term that did not eventually have this function called on it repeatedly!) so it helped to cache it, but now it is extremely rare, with some changes I'm making to RedPRL now. So, it actually hinders performance to cache this.
Close #109