Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback label selectinput #882

Merged
merged 7 commits into from
Feb 24, 2025
Merged

fix: rollback label selectinput #882

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d8b3a7f
fix: rollback for <label> condition removing the HTMLfor
Wagner3UB Feb 18, 2025
eae9df5
chore: release.md
Wagner3UB Feb 18, 2025
c4c6617
fix: htmlFor and condition to labeledby
Wagner3UB Feb 19, 2025
72cdeba
Update src/components/SelectInput/SelectInput.jsx
Wagner3UB Feb 20, 2025
1319735
Update src/components/SelectInput/SelectInput.jsx
Wagner3UB Feb 20, 2025
e059e9e
Update src/components/SelectInput/SelectInput.jsx
Wagner3UB Feb 20, 2025
0af36f2
Update src/components/SelectInput/SelectInput.jsx
Wagner3UB Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,20 @@
- ...
-->

## Versione X.X.X (dd/mm/yyyy)

### Migliorie

- ...

### Novità

- ...

### Fix

- Condizione per la Label per i select ripristinata.

## Versione 11.26.5 (06/02/2025)

### Migliorie
Expand Down
3 changes: 2 additions & 1 deletion src/components/SelectInput/SelectInput.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ const SelectInput = ({
const Select = reactSelect.default;
return (
<div className="bootstrap-select-wrapper">
{label && <label htmlFor={id}>{label}</label>}
<Select
components={{
MenuList,
Expand All @@ -347,7 +348,7 @@ const SelectInput = ({
isMulti={isMulti}
isClearable={isClearable}
aria-label={labelDefined}
aria-labelledby={labelledby}
aria-labelledby={!label ? labelledby : ''}
aria-live="polite"
ariaLiveMessages={getSelectAriaLiveMessages(intl)}
noOptionsMessage={() =>
Expand Down