Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial groundwork for command builders (#19) #20

Open
wants to merge 97 commits into
base: main
Choose a base branch
from

Commits on Nov 25, 2022

  1. Initial changes

    VelvetToroyashi committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    a3bffa9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1595549 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2022

  1. Configuration menu
    Copy the full SHA
    be84e1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b5329e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7d776ce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4c66ba4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    82997c3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e52da64 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    906facc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c87eceb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7ebccb8 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. Configuration menu
    Copy the full SHA
    c2b5c3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82ffb80 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1ae9c23 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    42f6bca View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3977af2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    871efe7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    39c1f7d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a6dcdc7 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Configuration menu
    Copy the full SHA
    9458e73 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b37a6a3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2292097 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bdfb089 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    83f103f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a7650f1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    697c61b View commit details
    Browse the repository at this point in the history
  8. Handle subcommands

    VelvetToroyashi committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    c465acb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    54e1294 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d371421 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0026db3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ecb5d3d View commit details
    Browse the repository at this point in the history
  13. Add real indexes to parameter shapes and order by that

    - Thanks to @uwx for suggesting this!
    VelvetToroyashi committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4596c92 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9892b94 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ef0ee8d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    655486c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    8873793 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    1ec2505 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Configuration menu
    Copy the full SHA
    5bdf616 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fcb67d1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9241d1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d4697d1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d8e546f View commit details
    Browse the repository at this point in the history
  6. Nullable

    VelvetToroyashi committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    96ae435 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bb1ac29 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a01ee60 View commit details
    Browse the repository at this point in the history
  9. Nonsensical null-forgiving operator usage

    - Suggested fix by uwx
    VelvetToroyashi committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    eeea846 View commit details
    Browse the repository at this point in the history
  10. Fix botched documentation in CoerceToValueTask

    - Fix suggested by uwx
    VelvetToroyashi committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    554a2d1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    fb9d087 View commit details
    Browse the repository at this point in the history
  12. Create delegate type for command invocations

    - Fix suggested by uwx
    VelvetToroyashi committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    bd99238 View commit details
    Browse the repository at this point in the history
  13. Improve(?) safety of builder for switches

    - Fix suggested by uwx; implementation may vary from desired
    VelvetToroyashi committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    4c0cae1 View commit details
    Browse the repository at this point in the history
  14. Inline variable

    - Fix suggested by uwx
    VelvetToroyashi committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    cc58f42 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b9cabcd View commit details
    Browse the repository at this point in the history
  16. Clean up code when creatin ga command shape

    - Fix suggested by uwx
    VelvetToroyashi committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    81ef88f View commit details
    Browse the repository at this point in the history
  17. Fix compiler errors

    VelvetToroyashi committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    4a07a68 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    ff66deb View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Indentation

    VelvetToroyashi committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ff499d3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b19431 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Configuration menu
    Copy the full SHA
    be535a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1690814 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ab6f10 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8b78a90 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3cdd5d9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1959c45 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Configuration menu
    Copy the full SHA
    2cc7f43 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f2835c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ed4a4b9 View commit details
    Browse the repository at this point in the history
  4. refactor: Formatting

    VelvetToroyashi committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    f7b0962 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8649ed6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    47e1816 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    38eebcc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e3a60c1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    504b5c4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dd439fb View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    aa7ac82 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Update Remora.Commands/Builders/CommandBuilder.cs

    Co-authored-by: uwx <[email protected]>
    Nihlus and uwx authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    254a77b View commit details
    Browse the repository at this point in the history
  2. Update Remora.Commands/Builders/CommandBuilder.cs

    Co-authored-by: uwx <[email protected]>
    Nihlus and uwx authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    f56179b View commit details
    Browse the repository at this point in the history
  3. Update Remora.Commands/Builders/CommandBuilder.cs

    Co-authored-by: uwx <[email protected]>
    Nihlus and uwx authored Sep 17, 2023
    Configuration menu
    Copy the full SHA
    f9a205f View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Configuration menu
    Copy the full SHA
    2aeb012 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. fix(builders): Return TSelf and cast

    This fixes an issue where methods were not chainable because the return type was the abstract class instead of TSelf. The cast to TSelf is safe by virtue of being an abstract class, so this will always be a derived class.
    VelvetToroyashi committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    21a6352 View commit details
    Browse the repository at this point in the history
  2. refactor(trees): Respect immutability (sorta) when merging commands

    This commit changes command merging to respect immutability; this comes at the cost of significantly more allocations which should be GC'd.
    VelvetToroyashi committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    b8b6097 View commit details
    Browse the repository at this point in the history
  3. fix(trees): Fix merging algorithm

    This commit fixes the merging algorithm by bringing it more in line with what ToChildNodes does. It also fixes an issue where top-level commands were not added to the root node.
    VelvetToroyashi committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    60a89b1 View commit details
    Browse the repository at this point in the history
  4. refactor(backend)!: Remove parameter indexes

    This commit removes `IParameterShape#ParameterIndex`
    
    The rationale behind this is that the parameter was only added in the first place to ensure that parameters were parsed in order, however this is moot as the order of the command parameters is determined by the order they're added/created in, anyway, and thus ordering them is just unneccesary overhead.
    
    BREAKING-CHANGE: ParameterIndex was part of the public-facing API and has since been removed. Consumers should store an index when iterating over the command parameters, or use `.IndexOf(T)` on the collection.
    VelvetToroyashi committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    63f2207 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    30d2c4a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6a4d11e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    91f9df0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6d4af34 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    34a7854 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    db7ea85 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5dac26a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0e5783d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    166667c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    1cef637 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Configuration menu
    Copy the full SHA
    8ec09ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b2a760a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    58a10bc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cd7ed3d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9a5530a View commit details
    Browse the repository at this point in the history