Fix autosave interval setting #1714
Merged
+74
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an off-by-one error when selecting the auto save interval: - Entry 0 is "disabled" - Entry 1 corresponds to index 0 in the interval array - Hence the maximum valid value is size() The code checked for >= size() and applied the "every GF" setting that is the last entry. Fix is to simply use `> size()` as the check. Fixes Return-To-The-Roots#1713
- Use enum as named IDs - Move more into the base class, like adding the edit and button - Show the savegame path for both save & load window - Update and translate comments
Flow86
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an off-by-one error when selecting the auto save interval:
The code checked for >= size() and applied the "every GF" setting that
is the last entry.
Fix is to simply use
> size()as the check.Fixes #1713
The new layout of the save window after the refactoring looks like this:
