-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
10 additions
and
103 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,18 @@ | ||
Contributing to Uber's Android Template | ||
======================= | ||
## Contributing | ||
|
||
Uber welcomes contributions of all kinds and sizes. This includes everything from from simple bug reports to large features. | ||
#### 1. Create an issue to make sure its something that should be done. | ||
|
||
Workflow | ||
-------- | ||
#### 2. Create a fork/branch. | ||
|
||
We love GitHub issues! | ||
#### 3. Do your work. | ||
Be sure to adhere to the prevailing style of the project. | ||
|
||
For small feature requests, an issue first proposing it for discussion or demo implementation in a PR suffice. | ||
#### 4. Write tests for your fix/new functionality. | ||
|
||
For big features, please open an issue so that we can agree on the direction, and hopefully avoid investing a lot of time on a feature that might need reworking. | ||
#### 5. Create a pull request to revenuecat/master and request review | ||
|
||
Small pull requests for things like typos, bug fixes, etc are always welcome. | ||
Explain in your pull request the work that was done, the reasoning, and that tests passed. | ||
|
||
DOs and DON'Ts | ||
-------------- | ||
#### 6. Make changes in response to review | ||
|
||
* DO follow our [coding style](https://github.com/uber/java-code-styles) | ||
* DO include tests when adding new features. When fixing bugs, start with adding a test that highlights how the current behavior is broken. | ||
* DO keep the discussions focused. When a new or related topic comes up it's often better to create new issue than to side track the discussion. | ||
|
||
* DON'T submit PRs that alter licensing related files or headers. If you believe there's a problem with them, file an issue and we'll be happy to discuss it. | ||
|
||
Guiding Principles | ||
------------------ | ||
|
||
* We allow anyone to participate in our projects. Tasks can be carried out by anyone that demonstrates the capability to complete them | ||
* Always be respectful of one another. Assume the best in others and act with empathy at all times | ||
* Collaborate closely with individuals maintaining the project or experienced users. Getting ideas out in the open and seeing a proposal before it's a pull request helps reduce redundancy and ensures we're all connected to the decision making process | ||
#### 7. Bask in the glory of community maintained software |