Skip to content

Commit

Permalink
Update contributing
Browse files Browse the repository at this point in the history
  • Loading branch information
jeiting committed Mar 29, 2018
1 parent 9a0b32f commit 369a9b5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 103 deletions.
34 changes: 0 additions & 34 deletions .travis.yml

This file was deleted.

46 changes: 0 additions & 46 deletions CODE_OF_CONDUCT.md

This file was deleted.

33 changes: 10 additions & 23 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,31 +1,18 @@
Contributing to Uber's Android Template
=======================
## Contributing

Uber welcomes contributions of all kinds and sizes. This includes everything from from simple bug reports to large features.
#### 1. Create an issue to make sure its something that should be done.

Workflow
--------
#### 2. Create a fork/branch.

We love GitHub issues!
#### 3. Do your work.
Be sure to adhere to the prevailing style of the project.

For small feature requests, an issue first proposing it for discussion or demo implementation in a PR suffice.
#### 4. Write tests for your fix/new functionality.

For big features, please open an issue so that we can agree on the direction, and hopefully avoid investing a lot of time on a feature that might need reworking.
#### 5. Create a pull request to revenuecat/master and request review

Small pull requests for things like typos, bug fixes, etc are always welcome.
Explain in your pull request the work that was done, the reasoning, and that tests passed.

DOs and DON'Ts
--------------
#### 6. Make changes in response to review

* DO follow our [coding style](https://github.com/uber/java-code-styles)
* DO include tests when adding new features. When fixing bugs, start with adding a test that highlights how the current behavior is broken.
* DO keep the discussions focused. When a new or related topic comes up it's often better to create new issue than to side track the discussion.

* DON'T submit PRs that alter licensing related files or headers. If you believe there's a problem with them, file an issue and we'll be happy to discuss it.

Guiding Principles
------------------

* We allow anyone to participate in our projects. Tasks can be carried out by anyone that demonstrates the capability to complete them
* Always be respectful of one another. Assume the best in others and act with empathy at all times
* Collaborate closely with individuals maintaining the project or experienced users. Getting ideas out in the open and seeing a proposal before it's a pull request helps reduce redundancy and ensures we're all connected to the decision making process
#### 7. Bask in the glory of community maintained software

0 comments on commit 369a9b5

Please sign in to comment.