Migrates to Coil 3 #2028
Draft
Migrates to Coil 3 #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayShortway
commented
Jan 6, 2025
| * Replaces all images in the [content] with the provided [color]. | ||
| */ | ||
| @InternalRevenueCatAPI | ||
| @ExperimentalCoilApi |
There was a problem hiding this comment.
I chose to propagate @ExperimentalCoilApi so we think twice if we accidentally try to use this in production code, as that would needlessly open us up to binary incompatibility issues if this experimental API changes.
1 build increased size
TestPurchasesUIAndroidCompatibility 1.0 (1)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 🗑 okhttp3 | ⬇️ -363.3 kB | ⬇️ -128.3 kB |
| 🗑 coil | ⬇️ -246.3 kB | ⬇️ -86.2 kB |
| 🗑 androidx.compose.foundation.text2 | ⬇️ -224.8 kB | ⬇️ -75.0 kB |
| 🗑 okhttp3 | ⬇️ -41.5 kB | ⬇️ -41.6 kB |
| 🗑 okio.internal._BufferKt | ⬇️ -24.9 kB | ⬇️ -10.4 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
📸 Snapshot Test15 modified, 115 unchanged
🛸 Powered by Emerge Tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This is a draft because it bumps Kotlin to 2.0.21.
Description
This PR updates Coil to 3.0.4. The maven coordinates have changed wrt Coil 2, which means there should be no binary incompatibility issues. For reference, the official migration docs are here.
PreviewHandlermechanism. Check outImagePreviews.kt.Motivation
The main motivation is Coil's new
PreviewHandlermechanism. This gives us great control over the images used in Compose previews, without changing production code. This comes in handy when creating previews for the Paywalls V2 image component, as it should handle various sizes and fit modes correctly. This automatically protects us against regressions in combination with Emerge Snapshots.