-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Paywalls V2] Parses UiConfig
#2068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
}, | ||
"localizations": { | ||
"en_US": { | ||
"monthly": "monthly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it should work... But if we receive unknown localization keys here, it should continue parsing only the known ones correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this didn't work, good call! I have "handling unknown enums" on my list, but decided to do this one now as it is slightly different because it's "handling unknown enums in a map (of maps)". e802ad6
"type": "name", | ||
"value": "SF Pro" | ||
}, | ||
"android": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a "secondary" font that uses google_fonts
for android? (I see we have one for web, but that would be ignored by the deserializer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! eed558c
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
==========================================
+ Coverage 81.35% 81.38% +0.02%
==========================================
Files 265 266 +1
Lines 8690 8793 +103
Branches 1235 1247 +12
==========================================
+ Hits 7070 7156 +86
- Misses 1116 1126 +10
- Partials 504 511 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahmm makes sense and looks good!
Description
Adds
UiConfig
toOffering
. This is the Android equivalent of RevenueCat/purchases-ios#4628. TheUiConfig
is not actually used yet. That will come in follow-up PRs.Lots of file and line changes, but not terribly complex.