Adds a LocalPreviewImageLoader CompositionLocal.
#2201
Draft
+240
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayShortway
commented
Feb 28, 2025
| @@ -72,6 +72,7 @@ import com.revenuecat.purchases.ui.revenuecatui.components.style.ImageComponentS | |||
| import com.revenuecat.purchases.ui.revenuecatui.composables.RemoteImage | |||
There was a problem hiding this comment.
I highly recommend reviewing this file with whitespace hidden on GitHub.
📸 Snapshot Test56 added, 206 unchanged
🛸 Powered by Emerge Tools |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2201 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 277 277
Lines 9460 9460
Branches 1335 1335
=======================================
Hits 7613 7613
Misses 1287 1287
Partials 560 560 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the
previewImageLoaderparameter inRemoteImagewith aLocalPreviewImageLoaderCompositionLocal. This is similar to how previews are handled in Coil 3.Motivation
This will be very helpful in rendering images in our template previews. Without this change, we would have to propagate the
previewImageLoaderparameter through the entire component tree, adding it to everyComponentView. This change avoids that, because we can just wrap our previewed composable inProvidePreviewImageLoader().