Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PaywallsTester by changing TestData DEBUG checks #4092

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix PaywallsTester by changing TestData DEBUG checks #4092

merged 1 commit into from
Jul 19, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Jul 19, 2024

Round 2 on #4087. There were still some stuff not being available to PaywallsTester on archive

@vegaro vegaro added the build label Jul 19, 2024
@vegaro vegaro requested a review from a team July 19, 2024 14:25
joshdholtz
joshdholtz approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense!

@vegaro vegaro merged commit fb7ea42 into main Jul 19, 2024
4 checks passed
@vegaro vegaro deleted the fix-test-data-visibility branch July 19, 2024 14:33
@fire-at-will fire-at-will mentioned this pull request Jul 23, 2024
Merged
nyeu pushed a commit that referenced this pull request Oct 2, 2024
@vegaro @nyeu
Fix PaywallsTester by changing TestData DEBUG checks (#4092)
e3c5eb2 
Round 2 on #4087. There
were still some stuff not being available to `PaywallsTester` on archive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
pr:other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vegaro @joshdholtz