-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Paywalls V2] Remove/replace PAYWALL_COMPONENTS
compiler flag and fix OS/platform compile issues
#4727
[Paywalls V2] Remove/replace PAYWALL_COMPONENTS
compiler flag and fix OS/platform compile issues
#4727
Changes from 27 commits
281c2a4
20a8e04
f21ff99
51e68a1
54f3151
86ebde8
6bbb72d
097248d
452b032
755971d
69ffbbe
85d6da1
6d3164f
4cae4b4
301412b
1cbadf1
4a7aacc
8e73a28
0147679
72f88ee
7f027a2
6f7b7af
8181c44
d6852c3
957ff6e
1b782cc
7c96e1d
6ae501b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ import Foundation | |
import RevenueCat | ||
import SwiftUI | ||
|
||
#if PAYWALL_COMPONENTS | ||
#if !os(macOS) && !os(tvOS) // For Paywalls V2 | ||
|
||
@available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | ||
struct TabControlToggleComponentView: View { | ||
|
@@ -83,7 +83,7 @@ private struct CustomToggleStyle: ToggleStyle { | |
.offset(x: configuration.isOn ? 10 : -10) | ||
) | ||
.onTapGesture { | ||
withAnimation(.smooth(duration: 0.2)) { | ||
withAnimation(.easeInOut(duration: 0.2)) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this intended? (Maybe There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah yeah, intended 😊 Had issues with |
||
configuration.isOn.toggle() | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking we want this removed from here, I see in the other change it was duplicated, but I don't see
PaywallTimelineComponent
in this section?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah yeah! It was added to both
RevenueCat
andRevenueCatUI
targets which was wrong 😅 So I removed theRevenueCatUI
one since this file is part of the offerings response codable stuffBut thanks for checking 🙏