Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention licensing information in README #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mention licensing information in README #149

wants to merge 1 commit into from

Conversation

ferki
Copy link
Member

@ferki ferki commented Apr 12, 2020

@krimdomu @ehuelsmann: this is the licensing information we discussed earlier briefly. IANAL, but I'd like to mention it in the README.

Copy link
Contributor

@ehuelsmann ehuelsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Fine by me.

@ehuelsmann
Copy link
Contributor

@krimdomu ping

@krimdomu
Copy link
Contributor

Fine for me

@ferki
Copy link
Member Author

ferki commented Oct 26, 2020

Fine for me

Thanks @krimdomu for stating your approval as a comment! Could you also approve it as a reviewer, please?

(Reasoning: it's possible to remove/edit the text of comments later, but approval seems to be logged as part of the issue history more permanently; I believe that's more formal/explicit, which feels like a better fit for the legal nature of question).

@ferki
Copy link
Member Author

ferki commented Oct 26, 2020

Based on my previous review of the repo, content by third party authors has been removed or rewritten. I believe that means if the three of us agrees on the new license, we can formally make the licensing change in order to make the contribution process smoother for future volunteers.

I'll do another review round later before merging.

@ehuelsmann
Copy link
Contributor

@ferki time to close this PR?

@ferki
Copy link
Member Author

ferki commented Oct 16, 2023

@ehuelsmann: right, it wasn't merged yet, despite the initial agreement and approval, from the three of us.

My last notes about this topic say that all the previous contributors would also need to approve the license – or perhaps we can review all previous contributions, and see if we still ship them or not.

I have to admit I did not feel the motivation and capacity so far to do such a review in preparation to merge, while I still definitely would like to see a clearly applied license to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants