Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): 🎸 ensure object safety of state's traits #692

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Jan 16, 2025

Purpose of this Pull Request

As described in the title.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo marked this pull request as ready for review January 16, 2025 03:36
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jan 16, 2025
wjian23
wjian23 previously approved these changes Jan 16, 2025
@M-Adoo M-Adoo enabled auto-merge January 16, 2025 05:55
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels Jan 16, 2025
@M-Adoo M-Adoo added this pull request to the merge queue Jan 16, 2025
@M-Adoo M-Adoo removed this pull request from the merge queue due to a manual request Jan 16, 2025
@M-Adoo M-Adoo added this pull request to the merge queue Jan 16, 2025
@M-Adoo M-Adoo removed this pull request from the merge queue due to a manual request Jan 16, 2025
@M-Adoo M-Adoo merged commit 7837509 into RibirX:master Jan 16, 2025
15 checks passed
@M-Adoo M-Adoo deleted the refactor/tabs branch January 16, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants