Fixed validation of JTokens with type Uri #1403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RicoSuter Is anyone still reviewing PR's that can take a look at this? |
RicoSuter
reviewed
Oct 25, 2021
|
Tests are failing, please fix if we should merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonSchemaValidator was not properly converting JTokens of type Uri to strings. Calling token.Value() would throw exception because Uri does not implement IConvertible. Instead Uri's ToString() should be used to convert to string.
Converted to switch statement to handle multiple different Type scenarios and added unit test to cover Uri case.