Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed parser option checks to allow artist search #310

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Spyridion
Copy link
Contributor

I noticed the if checks stop the artist tag from being used. I added the nots to allow the artist search to continue to the legacy search function.

@RicterZ RicterZ merged commit 4ecffaf into RicterZ:dev Mar 28, 2024
@Spyridion
Copy link
Contributor Author

Hi, I just noticed that the dev branch doesn't have the artist specific changes from master branch.

@Spyridion
Copy link
Contributor Author

Will you be cherry picking from dev into master?

@Spyridion
Copy link
Contributor Author

Spyridion commented Mar 28, 2024

I also had to do a sudo pip install lxml to get the build to work as well. I get this error otherwise: bs4.FeatureNotFound: Couldn't find a tree builder with the features you requested: lxml. Do you need to install a parser library?

@RicterZ
Copy link
Owner

RicterZ commented Mar 28, 2024

Merged to master branch.

Seems better to use soup = BeautifulSoup(s, "html.parser") to parse html content, this way isn't need lxml dependency

@Spyridion
Copy link
Contributor Author

Yeah, that makes sense. There were a couple changes I didn't notice between dev and main when I made this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants