address comments

flux_sdk/flux_core/data_models.py

@@ -5,18 +5,6 @@
 from typing import Optional
 
 
-class BaseExternalResponse:
-    """The base class for all the response from the third party system."""
-
-    is_app_disconnected: bool = False
-    """This indicates if the app is disconnected from the third-party system."""
-
-
-class BaseExternalRequest:
-    """The base class for all external request made to the third party system."""
-    pass
-
-
 class BaseCapability(ABC):
     """The base class for all capabilities."""
 
@@ -293,4 +281,11 @@ class TerminationType(Enum):
     OFFER_DECLINE = 5
     RESCIND = 6
     RENEGE = 7
+
+
+class AppDisconnectedError(Exception):
+    """
+    This exception is raised when the app is disconnected from the third-party system.
+    """
+    pass
 

flux_sdk/user_management/capabilities/user_lifecycle_management/interface.py

@@ -1,5 +1,5 @@
 from flux_sdk.flux_core.data_models import BaseCapability
-from flux_sdk.user_management.capabilities.user_lifecycle_management.data_models import (
+from flux_sdk.user_management.data_models.data_models import (
     GetOrganizationsRequest,
     GetOrganizationsResponse,
     GetUsersRequest,

flux_sdk/user_management/capabilities/user_lifecycle_management/data_models.py → flux_sdk/user_management/data_models/data_models.py

@@ -1,6 +1,5 @@
 from dataclasses import dataclass
 from typing import Optional
-from flux_sdk.flux_core.data_models import BaseExternalRequest, BaseExternalResponse
 
 
 @dataclass(kw_only=True)
@@ -38,30 +37,30 @@ class User:
 
 
 @dataclass(kw_only=True)
-class GetUsersRequest(BaseExternalRequest):
+class GetUsersRequest:
     """This represents a request to get users from the third party system."""
 
     organizations: Optional[list[Organization]] = None
     """The organizations to get users from. If this field is not provided, the users from all organizations should be returned."""
 
 
 @dataclass(kw_only=True)
-class GetUsersResponse(BaseExternalResponse):
+class GetUsersResponse:
     """This represents a response containing the users from the third party system."""
 
     users: list[User]
     """The users from the third party system."""
 
 
 @dataclass(kw_only=True)
-class GetOrganizationsRequest(BaseExternalRequest):
+class GetOrganizationsRequest:
     """This represents a request to get organizations from the third party system."""
 
     pass
 
 
 @dataclass(kw_only=True)
-class GetOrganizationsResponse(BaseHttpResponse):
+class GetOrganizationsResponse:
     """This represents a response containing the organizations from the third party system."""
 
     organizations: list[Organization]