Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sz2376 committed Sep 21, 2024
1 parent d727a2c commit 78a31ec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
8 changes: 0 additions & 8 deletions flux_sdk/flux_core/data_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@
import requests


class BaseCapability(ABC):
"""The base class for all capabilities."""

def __init__(self, session: requests.Session | None = None):
self.session = session
"""The session to make HTTP requests to the third party."""


class LeaveType(Enum):
VACATION = 1
WFH = 2
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from abc import abstractmethod
from flux_sdk.flux_core.data_models import BaseCapability
from abc import ABC, abstractmethod
from flux_sdk.user_management.data_models.data_models import (
GetOrganizationsRequest,
GetOrganizationsResponse,
Expand All @@ -8,7 +7,7 @@
)


class UserLifecycleManagement(BaseCapability):
class UserLifecycleManagement(ABC):
"""
This class represents the "user_lifecycle_management" capability.
This capability is used to manage the lifecycle of users in the third-party system with supports including:
Expand Down

0 comments on commit 78a31ec

Please sign in to comment.