Skip to content

Commit

Permalink
changed type of termination_date in Employee model from datetime to d…
Browse files Browse the repository at this point in the history
…ate (#52)

* changed type of termination_date in Employee model from datetime to date

* fixed a test

* fixed lint

* bumped flux-sdk v
  • Loading branch information
apurvrathore authored Mar 18, 2024
1 parent d999b32 commit e7de69f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions flux_sdk/flux_core/data_models.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from datetime import datetime
from datetime import date, datetime
from enum import Enum
from typing import Optional

Expand Down Expand Up @@ -84,7 +84,7 @@ class Employee:
business_email: str
personal_email: str
gender: Gender
termination_date: Optional[datetime]
termination_date: Optional[date]
w2_start_date: datetime
address: Address
status: EmployeeState
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os
import unittest
from datetime import datetime
from datetime import date, datetime
from decimal import Decimal

from flux_sdk.flux_core.data_models import (
Expand Down Expand Up @@ -81,7 +81,7 @@ def setUp(self) -> None:
employee.dob = datetime(1990, 1, 1)
employee.start_date = datetime(2020, 1, 1)
employee.original_hire_date = datetime(2020, 1, 1)
employee.termination_date = datetime(2020, 6, 1)
employee.termination_date = date(2020, 6, 1)
employee.start_date = datetime(2021, 1, 1)
employee.status = EmployeeState.ACTIVE
employee.is_international_employee = False
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os
import unittest
from datetime import datetime
from datetime import date, datetime
from decimal import Decimal

from flux_sdk.flux_core.data_models import (
Expand Down Expand Up @@ -70,7 +70,7 @@ def setUp(self) -> None:
employee.dob = datetime(1990, 1, 1)
employee.start_date = datetime(2020, 1, 1)
employee.original_hire_date = datetime(2020, 1, 1)
employee.termination_date = datetime(2020, 6, 1)
employee.termination_date = date(2020, 6, 1)
employee.start_date = datetime(2021, 1, 1)
employee.gender = Gender.FEMALE
employee.is_full_time = True
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "rippling-flux-sdk"
version = "0.18"
version = "0.19"
description = "Defines the interfaces and data-models used by Rippling Flux Apps."
authors = ["Rippling Apps <[email protected]>"]
readme = "README.md"
Expand Down

0 comments on commit e7de69f

Please sign in to comment.