Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed type of termination_date in Employee model from datetime to date #52

Merged
merged 4 commits into from
Mar 18, 2024
Merged

changed type of termination_date in Employee model from datetime to date #52

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59327f0
changed type of termination_date in Employee model from datetime to date
apurvrathore Mar 14, 2024
6abd221
fixed a test
apurvrathore Mar 14, 2024
a58b0e3
fixed lint
apurvrathore Mar 14, 2024
8df9f20
bumped flux-sdk v
apurvrathore Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flux_sdk/flux_core/data_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from datetime import datetime
from datetime import date, datetime
from enum import Enum
from typing import Optional

Expand Down Expand Up @@ -84,7 +84,7 @@ class Employee:
business_email: str
personal_email: str
gender: Gender
termination_date: Optional[datetime]
termination_date: Optional[date]
w2_start_date: datetime
address: Address
status: EmployeeState
Expand Down
4 changes: 2 additions & 2 deletions flux_sdk/pension/utils/tests/test_ascensus/test_ascensus_180.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os
import unittest
from datetime import datetime
from datetime import date, datetime
from decimal import Decimal

from flux_sdk.flux_core.data_models import (
Expand Down Expand Up @@ -81,7 +81,7 @@ def setUp(self) -> None:
employee.dob = datetime(1990, 1, 1)
employee.start_date = datetime(2020, 1, 1)
employee.original_hire_date = datetime(2020, 1, 1)
employee.termination_date = datetime(2020, 6, 1)
employee.termination_date = date(2020, 6, 1)
employee.start_date = datetime(2021, 1, 1)
employee.status = EmployeeState.ACTIVE
employee.is_international_employee = False
Expand Down
4 changes: 2 additions & 2 deletions flux_sdk/pension/utils/tests/test_pay_konnect/test_pay_konnect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os
import unittest
from datetime import datetime
from datetime import date, datetime
from decimal import Decimal

from flux_sdk.flux_core.data_models import (
Expand Down Expand Up @@ -70,7 +70,7 @@ def setUp(self) -> None:
employee.dob = datetime(1990, 1, 1)
employee.start_date = datetime(2020, 1, 1)
employee.original_hire_date = datetime(2020, 1, 1)
employee.termination_date = datetime(2020, 6, 1)
employee.termination_date = date(2020, 6, 1)
employee.start_date = datetime(2021, 1, 1)
employee.gender = Gender.FEMALE
employee.is_full_time = True
Expand Down
Loading