implement PayKonnect 360 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshanmukrao
reviewed
Mar 26, 2024
| eds.ssn = ssn | ||
| eds.effective_date = effective_date | ||
| eds.deduction_type = deduction_type | ||
| eds.value = Decimal(value) # type: ignore |
There was a problem hiding this comment.
why do you need to type: ignore ?
There was a problem hiding this comment.
EmployeeDeductionSetting.value is given as float. But from other 401k apps that are implemented, it was always declared as Decimal in flux-apps.
flux_sdk/pension/utils/tests/test_pay_konnect/test_pay_konnect_180.py
Outdated
Show resolved
Hide resolved
pshanmukrao
reviewed
Apr 2, 2024
flux_sdk/pension/utils/pay_konnect_update_deduction_elections.py
Outdated
Show resolved
Hide resolved
flux_sdk/pension/utils/tests/test_pay_konnect/test_pay_konnect_update_deduction_elections.py
Outdated
Show resolved
Hide resolved
vguptarippling
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rippling.atlassian.net/browse/BENPNP-5, https://rippling.atlassian.net/browse/INSURANCE-74722
implement paykonnect 360
Majority of this is taken from existing ascensus 360 apart from field name changes.
For paykonnect 180, I was asked to remove errors if dob is not present. We should still upload irrespective of this