Merge pull request #1478 from ondrejmirtes/fix-abstract-property

Property from interface is abstract property
Roave · Jan 24, 2025 · c1326ba · c1326ba
2 parents 56df7b3 + 67a41c7
commit c1326ba
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/src/Reflection/ReflectionProperty.php b/src/Reflection/ReflectionProperty.php
@@ -309,7 +309,8 @@ public function isFinal(): bool
 
     public function isAbstract(): bool
     {
-        return (bool) ($this->modifiers & ReflectionPropertyAdapter::IS_ABSTRACT_COMPATIBILITY);
+        return (bool) ($this->modifiers & ReflectionPropertyAdapter::IS_ABSTRACT_COMPATIBILITY)
+            || $this->declaringClass->isInterface();
     }
 
     public function isPromoted(): bool

diff --git a/test/unit/Fixture/PropertyHooks.php b/test/unit/Fixture/PropertyHooks.php
@@ -164,3 +164,8 @@ class FinalPropertyHooks
         final set => strtolower($value);
     }
 }
+
+interface InterfaceWithProperty
+{
+    public int $abstractPropertyFromInterface { get; set; }
+}
diff --git a/test/unit/Reflection/ReflectionPropertyTest.php b/test/unit/Reflection/ReflectionPropertyTest.php
@@ -1021,6 +1021,15 @@ public function testIsAbstract(): void
         self::assertTrue($hookProperty->isAbstract());
     }
 
+    public function testIsAbstractInInterface(): void
+    {
+        $reflector = new DefaultReflector(new SingleFileSourceLocator(__DIR__ . '/../Fixture/PropertyHooks.php', $this->astLocator));
+        $classInfo = $reflector->reflectClass('Roave\BetterReflectionTest\Fixture\InterfaceWithProperty');
+
+        $abstractProperty = $classInfo->getProperty('abstractPropertyFromInterface');
+        self::assertTrue($abstractProperty->isAbstract());
+    }
+
     public function testNoHooks(): void
     {
         $classInfo = $this->reflector->reflectClass(ExampleClass::class);