Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45209: Fix E721 lint warning (type comparison) #153

Merged
merged 1 commit into from
Jul 12, 2024
Merged

DM-45209: Fix E721 lint warning (type comparison) #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/eups/Product.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,11 @@ def getConfig(self, section="DEFAULT", option=None, getType=None):

if option:
try:
if getType == bool:
if getType is bool:
return config.getboolean(section, option)
elif getType == float:
elif getType is float:
return config.getfloat(section, option)
elif getType == int:
elif getType is int:
return config.getint(section, option)
else:
return config.get(section, option)
Expand Down
4 changes: 2 additions & 2 deletions python/eups/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def printVersion(self, strm=sys.stderr):
return 0

def _issubclass(self):
return isinstance(self, EupsCmd) and type(self) != EupsCmd
return isinstance(self, EupsCmd) and type(self) is not EupsCmd

def err(self, msg, volume=0):
"""
Expand Down Expand Up @@ -2885,7 +2885,7 @@ def execute(self):

#-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-


class TagsCmd(EupsCmd):

usage = """%prog tags [-h|--help] [options] [tagname] [product]
Expand Down
Loading