-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it possible tu use :GpWhisper <LANGUAGE> #125
Conversation
@Robitx you mentioned pending comments but I dont see any ? could you precise please |
@teto sorry, I've forgot the review in the pending state 🤦♂️ |
ha yeah the log commands interrupt the user, quite bad ^^''' |
@teto another PR, I can do the logging soon but I'm currently rewriting the Prompt function used in the hooks because the signature got a bit unwieldy with multiple providers and leads to bugs. (Sadly another necessary breaking change). For logging I wouldn't drag another dependency just for this
Lines 547 to 574 in 0878f2f
|
3cc206e
to
2d45996
Compare
rebased, addressed comments and updated the doc. Tested locally with French and English. Worked nicely.
I was not proposing to add a dependency (yet :) ) but just to copy/paste that file into our codebase. |
@teto btw. the |
set tab by default
so this can be changed on the fly.
2d45996
to
6a7a78f
Compare
How do you prefer to work ? once approved, the committer can selfmerge ? |
@teto I've enabled auto merge so next time, the approved PR should get merged automatically. With this one feel free to merge it. |
so this can be changed on the fly.
Ideally I would like to be able to pass it an existing file too but I wanted to do a minimum first contribution. Also I develop on top of #93 which doesn't help