Sanitize exported file names to fix error during export #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightriff
changed the title
othomson-roblox
previously approved these changes
Jan 22, 2025
Nightriff
dismissed
othomson-roblox’s stale review
The base branch was changed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67 where Blender allows object names to contain characters considered to be invalid for a file name by the operating system. Since this add-on uses the object name as the file name, an error occurs during export.
This PR fixes the problem by "sanitizing" (removing) any characters that are not
isalnum()or in a set of other allowed characters., and_.Since this could result in an empty file name for objects that only contain invalid characters in their name, the file is also prefixed with
exported_to ensure it has a valid file name.