Fixed item stuck on cursor when unequipping set #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot mate, do you know when this fix will get released with an updated version ? |
I don't, but the bug is only present when a set is unequipping and item and it would result in a blank slot. So if you simply have a shirt on in your normal set, and the shirt off in your flask set, it will work fine. And change your macro accordingly: #showtooltip Diamond Flask |
|
This also fixed #250 |
|
Sorry for the delay. Is this still relevant? |
|
Yes |
|
@emrus-main does this also work outside of SoD? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: When you have no shirt equipped, and you equip a set with a shirt and unequip the set, the shirt will get stuck on the cursor producing a "Swap stopped. Something is on the cursor" error.
Issue: ItemRackEquip.lua checks the following line to determine if an item should be unequipped or replaced.
283: if swap[k]==0 then -- if intended to be emptyHowever,
swap[k] == "0"not0, due to a change in commit 9c52da4 infunction ItemRack.GetID(bag,slot)which appends runeSuffix or "" to all itemlinks.Solution: ItemRack.GetID only appends runeSuffix if it is not just an empty string. Alternative solution would be to change line 283 to
283: if swap[k]==0 or swap[k]=="0" then -- if intended to be emptyFixes: #254
Fixes: #249