[CHORE] 마이페이지 러닝기록 / 제목 수정 시, 키보드 완료 버튼 누르면 바로 수정되도록 변경 #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unam98
approved these changes
Nov 5, 2023
Comment on lines
88
to
+93
| private fun addListener() { | ||
| initBackButtonClickListener() | ||
| initShowMoreButtonClickListener() | ||
| initEditFinishButtonClickListener() | ||
| initTitleEditorActionDoneListener() | ||
| } |
There was a problem hiding this comment.
addListener에 포함되는 함수들을 아래에 순서대로 배치해주신 것 좋았습니다~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
✨ 작업 내용
✨ PR 포인트
굉장히 사소하지만 이런 걸로도 사용자 경험이 개선될 수 있다고 느꼈습니다!
코드 변경 사항 얼마되지 않으니 빠른 확인 부탁드립니다 :)
좋은 코드가 무엇인가를 고민하다가 개발 속도가 너무 더뎌지는 거 같아서, 이제는 좀 속도를 내보려고 합니다!!
데드라인 맞추는 것도 타 파트와의 협업에서 굉장히 중요하니까요!
그리고 이번 이슈처럼 자잘한 것들도 계속해서 개선해나가겠습니다! 화이팅!