[FEAT] 코스 그리기 / 코스 제목 입력 후 키보드 내리기 #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeha
requested changes
Nov 9, 2023
| @@ -311,6 +313,9 @@ class DrawActivity : | |||
| } | |||
|
|
|||
| btnCreateCourse.setOnClickListener { | |||
| val imm = getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager | |||
| imm.hideSoftInputFromWindow(etCourseName.windowToken, 0) | |||
|
|
|||
There was a problem hiding this comment.
기존에 구현되어 있는 hideKeyboard 라는 확장 함수 이용하면 더 좋을 거 같습니다!
그리고 실행 결과 보니까 키보드 뿐만 아니라 바텀 시트 자체가 dismiss 되는 게 좋을 거 같아요!
There was a problem hiding this comment.
넵! 말씀해주신 두 항목 다 반영해서 커밋 올렸습니다!
leeeha
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
closed #276
✨ 작업 내용
✨ PR 포인트
말씀해주셨던 동작이 아래 영상과 같을까요? 다르다면 알려주세요! 반영하겠습니다!
📸 스크린샷/동영상
KakaoTalk_20231109_142218589.mp4