[REFACTOR] 코스 발견 / 전면 리팩토링 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/refactor-course-discover-screen
- 뷰홀더 안의 onBind 함수에서 역할에 따라 함수화 - 중복되는 이미지 로딩 코드는 바인딩 어댑터 사용
- StorageRepository, CourseRepository에서 로직이 동일한 함수 중에 하나만 남김. - UiStateV2 코드 일부 적용 - data layer에서 service, source, data/repository, domain/repository 코드 전면 수정
- 생성자로 context 넘기지 않도록 - On[Where/What]ItemClick 으로 네이밍 통일
런타임에 예외를 던져서 앱이 죽어버리는 현상을 방지하기 위해
나중에 로직 다시 설계할 예정
unam98
reviewed
Dec 11, 2023
| } | ||
|
|
||
| fun getRecommendCourses(pageNo: Int) { | ||
| viewModel.getRecommendCourse(pageNo = pageNo, "date") |
There was a problem hiding this comment.
아마 복붙 이슈로 이쪽 함수에서 named argument가 누락된 것 같은데 전반적으로 확인 한 번 부탁드립니다!!
unam98
reviewed
Dec 11, 2023
| super.onScrolled(recyclerView, dx, dy) | ||
|
|
||
| // 스크롤을 내리면 원형 버튼이 보이도록 | ||
| if (dy > 0) { |
There was a problem hiding this comment.
여기 숫자 0이 무슨 의미인지 잘 모를 수 있으니 상수로 적어주시면 이해에 도움이 될 것 같습니다!
unam98
reviewed
Dec 11, 2023
| private fun initAppBarOffsetChangedListener() { | ||
| // CollapsingToolbarLayout의 높이가 완전히 확장되면 텍스트가 포함된 버튼이 보이도록 | ||
| binding.appBarDiscover.addOnOffsetChangedListener { appBarLayout, verticalOffset -> | ||
| if (verticalOffset == 0) { |
There was a problem hiding this comment.
여기도 숫자 0을 상수로 바꿔주시면 이해에 도움이 될 것 같아요!
unam98
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
✨ 작업 내용
✨ PR 포인트
📸 스크린샷/동영상
course_discover.mp4