[REFACTOR] 카카오 로그인 리팩토링 #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeha
reviewed
Dec 20, 2023
| } | ||
| } | ||
|
|
||
|
|
||
| private fun initKakaoAccountLogin() { | ||
| instance.loginWithKakaoAccount(contextRef.get()!!, callback = callback) |
There was a problem hiding this comment.
카카오톡 로그인에 실패해서 카카오 계정으로 로그인 재시도했는데, 이것도 실패하면 어떻게 되나요??
그에 대한 처리를 이 부분에서 해줘야 하지 않을까 싶어서 여쭤봅니다!
app/src/main/java/com/runnect/runnect/presentation/login/KakaoLogin.kt
Outdated
Show resolved
Hide resolved
|
|
||
| // 카카오톡에 연결된 카카오계정이 없는 경우, 카카오계정으로 로그인 시도 | ||
| initKakaoAccountLogin() | ||
| } else if (token != null) { |
There was a problem hiding this comment.
음 else if 대신에 early return 방식을 사용하면 코드가 조금 더 깔끔해질 거 같습니다!
if (error != null) {
// ...
// 여기서 early return
}|
|
||
| const val KAKAO_TALK_LOGIN_SUCCESS = "카카오톡으로 로그인 성공" | ||
| const val KAKAO_TALK_LOGIN_FAILURE = "카카오톡으로 로그인 실패" | ||
|
|
There was a problem hiding this comment.
다른 곳에서 사용되지 않는 문자열이라면, 습관적으로 private 지정자도 붙여주는 게 좋을 거 같습니다!
unam98
force-pushed
the
develop
branch
2 times, most recently
from
9538b84 to
55b4ded
Compare
sxunea
reviewed
Dec 20, 2023
app/src/main/java/com/runnect/runnect/presentation/login/KakaoLogin.kt
Outdated
Show resolved
Hide resolved
sxunea
reviewed
Dec 20, 2023
Comment on lines
14
to
15
| private val contextRef = WeakReference(context) | ||
| private val viewModelRef = WeakReference(viewModel) |
There was a problem hiding this comment.
WeakReference 직접 사용하는 예시는 개인적으로 처음봤는데 덕분에 공부해봤습니다 👍
unam98
force-pushed
the
feature/refactor-kakao-login
branch
from
cd9553a to
55b4ded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
✨ 작업 내용
✨ PR 포인트
📸 스크린샷/동영상