-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 코스 발견 / 추천 코스 정렬 기능 #313
Closed
Closed
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
f7a0a07
[FEAT] #307 정렬 버튼을 클릭하면 해당 기준으로 서버에 추천 코스 리스트를 요청하는 코드 추가
leeeha 98fbf91
[MOD] #308 마라톤, 추천 코스 조회 로직 수정
leeeha 23cd32a
[MERGE] #307 브랜치 병합
leeeha 2b8b8d9
[FEAT] #307 정렬된 리스트로 추천 코스 목록 전체를 갱신하고, 어댑터에 notify 하도록 구현
leeeha 2ce1684
[MOD] #307 첫 페이지를 조회하는 함수의 인자 변경
leeeha 724d0a5
[FEAT] #307 RecommendCourseViewHolder 안에서 정렬 버튼 클릭 리스너 정의
leeeha 5f59dc4
[CHORE] #307 로그 메시지 추가
leeeha 4e22b9d
[UI] #307 정렬 버튼 클릭에 따라 텍스트 스타일 변경
leeeha dc8d064
[FIX] #308 추천 코스까지 모두 로딩되었을 때만 canScrollVertically 함수가 실행되도록 변경
leeeha b2dff9b
Merge branch 'feature/fix-multiview-recyclerview-loading' of https://…
leeeha 1e1ed07
[MOD] #307 추천 코스 영역을 헤더와 코스 부분으로 타입 분리하기
leeeha 7e742e0
[FIX] #307 정렬 기준을 전환할 때마다 페이지 번호도 1로 초기화 하도록 변경
leeeha b859b10
[FIX] #308 외부 리사이클러뷰의 어댑터가 초기화 되었는지 검사하는 코드 추가
leeeha 76dc6be
Merge branch 'feature/fix-multiview-recyclerview-loading' of https://…
leeeha 55a8f18
[DEL] #307 불필요한 주석 삭제
leeeha 6bfd6b1
[CHORE] #307 추천 코스 페이지 관련 데이터 초기화 하는 함수명 변경
leeeha 75d7215
[FIX] #308 마라톤 코스 조회에 성공한 경우에만 추천 코스 옵저버 실행
leeeha 3cc4704
[FEAT] #308 멀티뷰 아이템 클래스에 viewType 반환하는 함수 정의
leeeha ddb4f9e
Merge branch 'develop' of https://github.com/Runnect/Runnect-Android …
leeeha 9a00970
[MOD] #308 멀티뷰 어댑터 내부에서만 mutable 하도록 2차원 리스트 타입 변경
leeeha b7ac4d4
[MOD] #308 getItemViewType 함수 내용 변경
leeeha efd2e3c
[MOD] #308 멀티뷰 아이템 리스트가 비어있는 경우에는 어떤 데이터도 뷰에 바인딩 하지 않도록 구현
leeeha 71e4ab8
[MOD] #308 비어있는 리스트로 멀티뷰 어댑터 초기화 하도록 변경
leeeha 37a04f1
[CHORE] #308 리사이클러뷰 초기화 하는 함수의 선언 위치 변경
leeeha 0731708
[MOD] #308 리프레시 하면 멀티뷰 어댑터의 데이터 목록 모두 삭제하도록 변경
leeeha 6f3691f
[MOD] #308 getRecommendCourses 함수의 인자 변경
leeeha 2ac852f
[FIX] #308 마라톤 코스 아이템 데코레이션 한번만 적용하도록 변경
leeeha 07873d5
[MOD] #308 생성자에서 데이터 목록을 받도록 멀티뷰 어댑터 코드 변경
leeeha 75c015f
[MOD] #308 뷰홀더 생성하는 함수에서 인자의 타입 변경
leeeha 42da096
[MOD] #308 마라톤 코스에 의해 리사이클러뷰 어댑터 초기화 되면 추천 코스 리스트 추가
leeeha 1bae106
[MOD] #308 가독성을 위해 코드 흐름에 따라 함수의 선언 위치 변경
leeeha f4985c4
[MOD] #307 마라톤 코스로 리사이클러뷰 어댑터 초기화 한 다음 추천 코스 목록 추가하도록 변경
leeeha 5753c59
Merge branch 'feature/fix-multiview-recyclerview-loading' of https://…
leeeha 8344cac
[DEL] #307 refresh 하면 새로운 리스트로 초기화 되므로 clear 함수 삭제
leeeha 9540728
[FIX] #307 정렬에 사용되는 인자 이름 변경
leeeha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requireContext를 사용해보시는 건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요 지훈님! 리뷰 남겨주셔서 감사합니다 😄
requireContext를 사용하지 않은 이유는 여기 노션 문서를 참고해주세요!