Set the default ABI to C for extern blocks and extern functions #2806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the default ABI was set to Rust, which is not correct for extern blocks and extern functions. This patch changes the default ABI to C for these cases. gcc/rust/ChangeLog: * hir/rust-ast-lower-base.cc (ASTLoweringBase::lower_qualifiers): Change default ABI to C for extern functions (ASTLoweringBase::lower_extern_block): Likewise Signed-off-by: Nobel Singh <[email protected]>
nobel-sh
force-pushed
the
change_default_abi
branch
from
9daac5a to
fbe788c
Compare
CohenArthur
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
LGTM, waiting on @philberty as he owns that part of the code. thanks for looking into this :)
philberty
reviewed
Feb 3, 2024
|
apologies i see it now: Thanks for linking this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default ABI was set to Rust, which is incorrect for extern blocks and extern functions. This patch changes the default ABI to C for these cases.
Reference: https://doc.rust-lang.org/reference/items/functions.html#extern-function-qualifier
Zulip discussion: https://gcc-rust.zulipchat.com/#narrow/stream/266897-general/topic/extern.20blocks/near/346429045
gcc/rust/ChangeLog: