Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nr2.0: Run DefaultResolver::visit on PathInExpression #3418

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

powerboat9
Copy link
Collaborator

Based on #3416

Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that specific commit looks good so that PR is good to me, but I want to spend some time reviewing the one it's based on

gcc/rust/ChangeLog:

	* resolve/rust-late-name-resolver-2.0.cc
	(Late::visit): When visiting a PathInExpression instance, call
	into DefaultResolver::visit, ensuring generic arguments are
	visited.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove entries.

Signed-off-by: Owen Avery <[email protected]>
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty philberty added this to the Name Resolution 2.0 rework milestone Feb 19, 2025
@philberty philberty added this pull request to the merge queue Feb 19, 2025
Merged via the queue into Rust-GCC:master with commit c638b4f Feb 19, 2025
12 checks passed
@powerboat9 powerboat9 deleted the fix-pen-1 branch February 19, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants