Get rid of duplicate interface #3396 #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel free to use |
GS-GOAT
force-pushed
the
master
branch
4 times, most recently
from
c343ee7 to
b2e4de9
Compare
gcc/rust/ChangeLog: * typecheck/rust-autoderef.cc (insert_implicit_type): Update single-parameter call to pass explicit HirId. * typecheck/rust-hir-type-check-expr.cc: Same. * typecheck/rust-hir-type-check-pattern.cc: Same. * typecheck/rust-hir-type-check.h: Removed call to the duplicate interface. * typecheck/rust-typecheck-context.cc (TypeCheckContext::insert_implicit_type): Removed the interface with no HirId field. Signed-off-by: Guransh Singh <[email protected]>
|
@powerboat9 Thanks. |
|
@philberty These changes include all the instances where the call was made to the interface without HirId. |
P-E-P
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated single-parameter calls to pass an explicit HirId alongside the type.
This refactor ensures that all calls to insert_implicit_type consistently use the two-parameter version, improving clarity and maintainability of type mapping tracking.
Fixes #3396
Signed-off-by: Guransh Singh [email protected]